#699 closed upgrade (Done)
NEED_VERSION needs to be extended for version 4.2
Reported by: | m.hadfield | Owned by: | arango |
---|---|---|---|
Priority: | major | Milestone: | Release ROMS/TOMS 3.7 |
Component: | Nonlinear | Version: | 3.7 |
Keywords: | Cc: |
Description (last modified by )
In makefile at line 31 the NEED_VERSION variable is defined to admit versions from 3.80 through 4.1. Gnu make 4.2 has now been sighted in the wild and should be added.
Change History (3)
comment:1 by , 9 years ago
Description: | modified (diff) |
---|---|
Resolution: | → Done |
Status: | new → closed |
comment:2 by , 9 years ago
And now Cygwin has upgraded make to 4.2.1!
I can see why this check was introduced, and why the limitations of make require the permitted versions to be hard-coded, but the updates are getting a bit tedious so perhaps it's time to drop it.
How about have make print a message like the following on every invocation:
"The ROMS makefile requires Gnu make with a version number > 3.80"
comment:3 by , 9 years ago
Yes, I changed to test to be instead:
ifneq (3.80,$(firstword $(sort $(MAKE_VERSION) 3.80))) $(error This makefile requires GNU make version 3.80 or higher. \ Your current version is: $(MAKE_VERSION)) endif
Please update your code.
Good to know, thank you Mark!