Possible bug in Utility/normalization.F

[hjsong]

Hi all,

While working on correcting wind forcing in IS4DVAR, I found something suspicious.

Utility/normalization.F looks like

Code: Select all

# if defined ADJUST_WSTRESS || defined ADJUST_STFLUX  (line 2236)
          ......
          ......
      IF (LwrtNRM(ifile,ng)) THEN                     (line 2244)
          ......
          ......
# endif                                               (line 2488)
# if defined ADJUST_STFLUX && defined SOLVE3D         (line 2489)
          ......
          ......
      END IF                                          (line 2636)
# endif                                               (line 2637)

So there will be an error if only 'ADJUST_WSTRESS' is defined.

I can see the same suspicious structure later in this code.

Code: Select all

# if defined ADJUST_WSTRESS || defined ADJUST_STFLUX  (line 4527)
          ......
          ......
      IF (LwrtNRM(ifile,ng)) THEN                     (line 4535)
          ......
          ......
# endif                                               (line 4722)
# if defined ADJUST_STFLUX && defined SOLVE3D         (line 4724)
          ......
          ......
      END IF                                          (line 4855)
# endif                                               (line 4856)

I could be wrong, so please check this part.

Thank you.
Hajoon

[arango]

This was corrected several weeks ago. You need to update your code.

[arango]

OK. This is a new one It only appeared when the ADJUST_WSTRESS is activated alone. Thank you for reporting this problem. This is now corrected in the following trac ticket.

Please update

[hjsong]

Dear Hernan,

Thank you.
I got that error when I turned on ONLY "ADJUST_WSTRESS".
I will update it!

Best,
Hajoon