Changes between Initial Version and Version 1 of Ticket #478


Ignore:
Timestamp:
12/30/10 21:53:34 (15 years ago)
Author:
arango
Comment:

Yes, good catch. However, the I- and J-range needs to be instead: 

      DO j=Jstr,JendR
        DO i=Istr,IendR
          IF ((rmask...   THEN
            pmask(i,j)=1.0_r8
          ...
        END DO
      END DO

Notice that periodic boundary conditions and MPI exchange is done after the re-computation for free-slip/no-slip. The Iend+1 and Jend+1 has a different meaning in tiled configurations.

Warning: This change to the code will affect your solution because of a change to the PSI mask at the grid edges.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #478

    • Property Resolution → Fixed
    • Property Status new → closed

  • Ticket #478 – Description

    initial v1  
    1 During initialization, the psi_mask is recomputed in metrics.F.  The range for this is:
     1During initialization, the mask at PSi_points is recomputed in '''metrics.F'''.  The range for this is:
    22
     3
     4{{{
    35      DO j=Jstr,Jend
    46        DO i=Istr,Iend
    57          IF ((rmask...   THEN
    68            pmask(i,j)=1.0_r8
    7 etc etc.
     9          ...
     10        END DO
     11      END DO
     12}}}
    813
    9 But the pmask has a range from Istr:Iend+1, and Jstr:Jend+1.  So I think this range should be Istr,Iend+1 and Jstr,Jend+1.
     14But the '''pmask''' has a range from '''Istr:Iend+1''', and '''Jstr:Jend+1'''.  So I think this range should be '''Istr,Iend+1''' and '''Jstr,Jend+1'''.