Compile Error after updating to ticket #966

[JMette]

Hi together,

after updating to ticket #966 and following, my applications cannot compile anymore with following error.

Code: Select all

  416 |      &                  LBi, UBi, LBj, UBj, ubar(:,:,1))
      |                                                        1
Error: Type mismatch in argument ‘ubj’ at (1); passed REAL(8) to INTEGER(4)
analytical.f90:423:56:

  423 |      &                  LBi, UBi, LBj, UBj, vbar(:,:,1))
      |                                                        1
Error: Type mismatch in argument ‘ubj’ at (1); passed REAL(8) to INTEGER(4)
analytical.f90:443:56:

  443 |      &                  LBi, UBi, LBj, UBj, zeta(:,:,1))
      |                                                        1
Error: Type mismatch in argument ‘ubj’ at (1); passed REAL(8) to INTEGER(4)
analytical.f90:470:65:

  470 |      &                  LBi, UBi, LBj, UBj, 1, N(ng), u(:,:,:,1))
      |                                                                 1
Error: Type mismatch in argument ‘ubk’ at (1); passed REAL(8) to INTEGER(4)
analytical.f90:477:65:

  477 |      &                  LBi, UBi, LBj, UBj, 1, N(ng), v(:,:,:,1))
      |                                                                 1
Error: Type mismatch in argument ‘ubk’ at (1); passed REAL(8) to INTEGER(4)
analytical.f90:504:72:

  504 |     &                    LBi, UBi, LBj, UBj, 1, N(ng), t(:,:,:,1,itrc))
      |                                                                       1

Error: Type mismatch in argument ‘ubk’ at (1); passed REAL(8) to INTEGER(4)
make: *** [ROMS/Functionals/Module.mk:15: /home/jmette/roms_project/app-aurora-fine/Build_romsG/analytical.o] Error 1

This happens also with the upwelling test case, so I assume I have to change my application setup. But after looking through the changes, I'm still not sure what change causes this error and where I have to modify my application setup to work again.
I would be really thankful about some guidance here.

[arango]

Hi, you are using the old user customizable ana_initial.h. Compare with the released one. We must have:

Code: Select all

      IF (first) THEN
        first=.FALSE.
        DO i=1,SIZE(Stats,1)
          Stats(i) % checksum=0_i8b
          Stats(i) % count=0
          Stats(i) % min=Large
          Stats(i) % max=-Large
          Stats(i) % avg=0.0_r8
          Stats(i) % rms=0.0_r8
        END DO
      END IF

...

!
!  Report statistics.
!
      CALL stats_2dfld (ng, tile, iNLM, u2dvar, Stats(1), 0,            &
     &                  LBi, UBi, LBj, UBj, ubar(:,:,1))
      IF (DOMAIN(ng)%NorthEast_Corner(tile)) THEN
        WRITE (stdout,10) TRIM(Vname(2,idUbar))//': '//                 &
     &                    TRIM(Vname(1,idUbar)),                        &
     &                     ng, Stats(1)%min, Stats(1)%max
      END IF
      CALL stats_2dfld (ng, tile, iNLM, v2dvar, Stats(2), 0,            &
     &                  LBi, UBi, LBj, UBj, vbar(:,:,1))
      IF (DOMAIN(ng)%NorthEast_Corner(tile)) THEN
        WRITE (stdout,10) TRIM(Vname(2,idVbar))//': '//                 &
     &                    TRIM(Vname(1,idVbar)),                        &
     &                     ng, Stats(2)%min, Stats(2)%max
      END IF

See https://github.com/myroms/roms/pull/36 and https://github.com/myroms/roms_test/pull/23

[JMette]

Thank you very much, that does the trick. I just updated the ana_initial.h.