Possible bug in def_tides.F

[stef]

I have the following error:

Code: Select all

 Found Error: **   Line: 311      Source: ROMS/Utility/wrt_tides.F, wrt_tides_nf90

 WRT_TIDES_NF90 - error while writing variable: v_tide
             into detide harmonics NetCDF file: 
             ...

I tried to fix it as follows, but don't have a run long enough to validate the detided output, so I'm not sure it's right.

In

Code: Select all

ROMS/Utility/def_tides.F

, there is

Code: Select all

455:!  Define 3D v-momentum time-accumulated tide harmonics.
456-!
457-        IF (.not.got_var(idv3dH).and.Aout(idv3dD,ng)) THEN
--
1111:!  Define 3D v-momentum time-accumulated tide harmonics.
1112-!
1113-        IF (.not.got_var(idv3dH).and.Aout(idv3dD,ng)) THEN

Should this be

Code: Select all

455:!  Define 3D v-momentum time-accumulated tide harmonics.
456-!
457-        IF (Aout(idv3dD,ng)) THEN
--
1111:!  Define 3D v-momentum time-accumulated tide harmonics.
1112-!
1113-        IF (Aout(idv3dD,ng)) THEN

instead? That's equivalent to the condition for the u-momentum immediately above the lines posted.

[arango]

Yes. great catch. Thank you for reporting this problem. I missed those. It seems a little bit confusing to have two different indices. For example, idv3dD in the standard input file and idv3dH for the NetCDF variable metadata. This was introduced when I separated input tidal forcing and output detided fields. Perhaps, I need to clean that logic. But, I will have to change all the ROMS standard input files, which is an inconvenience to everybody.