Adjoint compilation error with define VISC4 and DIFF4

[xavierC]

Hello, i lately upgrade ROMS to the following version:
ROMS 3.9
GIT Root URL : https://www.myroms.org/git/src
GIT Revision : ef5d653689eff77de5a2302b0a00e2fd840506e4
SVN Root URL : https://www.myroms.org/svn/src/trunk
SVN Revision : 1002

Still with some trouble with my HF radar data i stepped back to the WC13 example and compilation option.
i therefore mainly shifted from KPP to GLS.
having some trouble with the Non linear version i changed the harmonic diffusion/viscosity to biharmonic, which make it work like a charm .

This where i started to compile I4DVAR and W4DPAS with those options:
#define ANA_BSFLUX
#define ANA_BTFLUX

#define UV_ADV
#define DJ_GRADPS
#define UV_COR
#define UV_QDRAG
#define UV_VIS4
#define MIX_GEO_UV
#define MIX_GEO_TS
#define SPLINES_VDIFF
#define SPLINES_VVISC
#define TS_DIF4
#define SOLVE3D
#define SALINITY
#define NONLIN_EOS
#define CURVGRID
#define PROFILE
#define SPHERICAL
#define MASKING


#if defined ARRAY_MODES || defined CLIPPING || \
defined IS4DVAR || defined IS4DVAR_SENSITIVITY || \
defined W4DPSAS || defined W4DPSAS_SENSITIVITY || \
defined W4DVAR || defined W4DVAR_SENSITIVITY
# define ADJUST_BOUNDARY
# define ADJUST_WSTRESS
# undef ADJUST_STFLUX
# define NL_BULK_FLUXES
# define VCONVOLUTION
# define IMPLICIT_VCONV
# ifdef BALANCE_OPERATOR
# define ZETA_ELLIPTIC
# endif
# define FORWARD_WRITE
# define FORWARD_READ
# define FORWARD_MIXING
# define OUT_DOUBLE
#endif


AND it Failled !!!

to compile it i had to add
USE mod_ncparam

in SUBROUTINE ad_t3dmix4_tile (ad_t3dmix4_geo.h line 118)
in SUBROUTINE ad_uv3dmix4_tile (ad_uv3dmix4_geo.h line 145)
in SUBROUTINE ad_step2d_tile (ad_step2d_LF_AM3.h line 225)

i am using
Currently Loaded Modulefiles:
3) intel-fc-16/16.0.4.258
2) mpt/2.15 4) NETCDF/4.3.3.1-mpt-intel2016


Not sure that's relevant to other users, but is it can help...
obviously mix4_s ans iso will need the same treatment.

[robertson]

Fixed in SVN Revision 1009 and Git cbc84128d7d33150dc40ade4821b82dce6ce5662. Details can be found here