Failure nesting_mod_mp_check_massflux

[RRicardo]

Hello all,

I compiled and tested roms for one grid and it is working fine.

When it comes to nested grids, I defined the same header file with option #define NESTING and made the corresponding changes to the .in file. Then it compiles normally but when I tested it shows the following error:
"Run-Time Check Failure. The variable 'nesting_mod_mp_check_massflux_$WESTSUM' is being used without being defined"

I don't know how to suppress this error.
Can anyone help me?

Thanks in advance.
Best regards
Rui

[jcwarner]

i think this was fixed already. can you do an update?
-j

[RRicardo]

i think this was fixed already. can you do an update?
-j

I tried only with ROMS with revision 761 (latest version).

I also tried with COAWST with the revision 988 2 grids for WRF and 2 grids for ROMS.

I always get the same error.

The interesting part is that when I tested the COAWST (revision 975) with Hurricane Sandy = 2 grids for WRF, 2 grids for ROMS, 2 grids for SWAN it worked fine.
But when I remove SWAN and make the changes and compile again, the same error occurs.

Thanks again.
Best regards
Rui

[jcwarner]

i just put in a ticket for this. i thought it was corrected previously. This westsum eastsum values are for error checking only. and will not alter the result. One thing you could do is look at the nesting.f90 and look for the variable westsum and see if it is truly used before being defined. are you running in debug mode?


-j

[RRicardo]

i just put in a ticket for this. i thought it was corrected previously. This westsum eastsum values are for error checking only. and will not alter the result. One thing you could do is look at the nesting.f90 and look for the variable westsum and see if it is truly used before being defined. are you running in debug mode?


-j

Since you have mentioned I compiled ROMS with the debug mode on and off and had the same error.
I will wait for the ticket answer, and continue trying to see if something comes up.

Thanks again.
Best regards
Rui

[RRicardo]

Hello again

We manage to put the 2 grids nesting in ROMS working by changing the line 753 in ROMS/Nonlinear/nesting.F
EastSum=WestSum+BRY_CONTACT(ieast,cr)%Mflux(Jbf)
to
EastSum=EastSum+BRY_CONTACT(ieast,cr)%Mflux(Jbf)

Is this a good fix?

Thanks again.

Best Regards
Rui

[jcwarner]

i submitted a ticket for this. There are 3 places to change:

" I thought we had taken care of this, but it is not corrected in the main repository. This is only for the error checking, and will not change results. But can you update this for nesting.F

1) line 754 has
EastSum=WestSum+BRY_CONTACT(ieast,cr)%Mflux(Jbf)
but should probably be
EastSum=EastSum+BRY_CONTACT(ieast,cr)%Mflux(Jbf)


2) 767 from
MFratio=REFINED(cr)%DU_avg2(1,m,tnew)/WestSum
to
MFratio=REFINED(cr)%DU_avg2(1,m,tnew)/EastSum


3) 871 from
MFratio=REFINED(cr)%DV_avg2(1,m,tnew)/SouthSum
to
MFratio=REFINED(cr)%DV_avg2(1,m,tnew)/NorthSum

"

[kate]

Then I assume line 870 should be:

Code: Select all

IF (NorthSum.ne.0) THEN