Changes between Initial Version and Version 1 of Ticket #750


Ignore:
Timestamp:
11/13/17 23:29:59 (8 years ago)
Author:
arango
Comment:

Yes, great catch and explanation. I missed removing that logic from FRC_FILE.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #750

    • Property Resolution → Fixed
    • Property Status new → closed

  • Ticket #750 – Description

    initial v1  
    1 The code in lines 659–714 of ROMS/include/globaldefs.h defines the symbol FRC_FILE. Then in lines 5576–5589 of ROMS/Utility/read_phypar.F the model checks for the existence of the file(s) specified by the FRCNAME entry in ocean.in. The globaldefs.h code defines FRC_FILE if, amongst other conditions, either SSH_TIDES or UV_TIDES is set: see line 700 if SOLVE3D is set and line 711 if it is not.
     1The code in lines 659–714 of '''ROMS/include/globaldefs.h''' defines the symbol '''FRC_FILE'''. Then in lines 5576–5589 of '''ROMS/Utility/read_phypar.F''' the model checks for the existence of the file(s) specified by the '''FRCNAME''' entry in '''ocean.in'''. The '''globaldefs.h''' code defines '''FRC_FILE''' if, amongst other conditions, either '''SSH_TIDES''' or '''UV_TIDES''' is set: see line 700 if '''SOLVE3D''' is set and line 711 if it is not.
    22
    3 However, tidal parameters are now read from special tidal-forcing files (entry TIDENAME), not from ordinary forcing files as they were previously. The current code fails when tides are required but with no other forcings.
     3However, tidal parameters are now read from special tidal-forcing files (entry '''TIDENAME'''), not from ordinary forcing files as they were previously. The current code fails when tides are required but with no other forcings.
    44
    5 The references in ROMS/include/globaldefs.h to "(defined SSH_TIDES || defined UV_TIDES)" in lines 700 & 711 should be removed.
     5The references in '''ROMS/include/globaldefs.h''' to
     6 {{{
     7 (defined SSH_TIDES || defined UV_TIDES)
     8}}}
     9in lines 700 & 711 should be removed.
    610