Changes between Initial Version and Version 1 of Ticket #666


Ignore:
Timestamp:
06/23/15 21:26:37 (10 years ago)
Author:
arango
Comment:

Indeed, I don't know what happened here. There were couple of typos that you missed. It was correct in my research version. I guess I only corrected my research version and I didn't correct the repositories. As you mentioned, these typos does not affect the nesting solutions since these quantities are only used to check mass and volume conservation at the contact regions during debugging.

Also thanks to John Wilkin for also reporting the same problem.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #666

    • Property Resolution → Fixed
    • Property Status new → closed

  • Ticket #666 – Description

    initial v1  
    1 I thought we had taken care of this, but it is not corrected in the main repository. This is only for the error checking, and will not change resutls. But can you update this for nesting.F
     1I thought we had taken care of this, but it is not corrected in the main repository. This is only for the error checking, and will not change results since this is the diagnostic quantities for debugging mass and volume conservation.  But can you update this for '''nesting.F''':
    22
    3 1) line 754 has
    4 EastSum=WestSum+BRY_CONTACT(ieast,cr)%Mflux(Jbf)
    5 but should probably be
    6 EastSum=EastSum+BRY_CONTACT(ieast,cr)%Mflux(Jbf)
     3 * Line 754 needs to change from
    74
    8 2) 767 from
     5{{{
     6                EastSum=WestSum+BRY_CONTACT(ieast,cr)%Mflux(Jbf)
     7to
     8                EastSum=EastSum+BRY_CONTACT(ieast,cr)%Mflux(Jbf)
     9}}}
     10
     11 * Line 767 needs to change from
     12
     13{{{
    914                MFratio=REFINED(cr)%DU_avg2(1,m,tnew)/WestSum
    1015to
    1116                MFratio=REFINED(cr)%DU_avg2(1,m,tnew)/EastSum
     17}}}
    1218
    13 3) 871 from
     19 * Line 817 needs to change from
     20
     21{{{
     22               IF (EastSum.ne.0) THEN
     23to
     24               IF (SouthSum.ne.0) THEN
     25}}}
     26
     27 * Line 859 needs to change from
     28
     29{{{
     30               m=BRY_CONTACT(isouth,cr)%C2Bindex(Ibf)    ! pick last one
     31to
     32               m=BRY_CONTACT(inorth,cr)%C2Bindex(Ibf)    ! pick last one
     33
     34}}}
     35
     36 * Line 869-870 need to change from
     37
     38{{{
     39              IF (EastSum.ne.0) THEN
    1440                MFratio=REFINED(cr)%DV_avg2(1,m,tnew)/SouthSum
    1541to
     42              IF (NorthSum.ne.0) THEN
    1643                MFratio=REFINED(cr)%DV_avg2(1,m,tnew)/NorthSum
     44}}}
    1745
    1846
    19