River direction (Dsrc)

[peisach]

This is not really a bug, but perhaps an inconsistency between the code and comments describing the code:

In mod_sources.F it is stated that the direction of rivers (SOURCES % Dsrc) should be zero for river flow along the xi-direction and larger than zero for flow along the eta-direction. And in pre_step3d.F, step2d.F and step3d_uv.F the IF-test roughly follows this convention:

Code: Select all

          IF (INT(Dsrc(is)).eq.0) THEN
            ...
          ELSE
            ...
          END IF

But in step3d_t.F Dsrc = 1 also receives special attention while any other positive (or negative) value of Dsrc is ignored:

Code: Select all

            IF (INT(Dsrc(is)).eq.0) THEN
              ...
            ELSE IF (INT(Dsrc(is)).eq.1) THEN
              ...
            END IF

Not a big deal, but somewhat confusing. By the comments in mod_sources.F (and also analytical.F) one might be tempted to specify any old value for Dsrc.

This seems to be the case for roms-2.1, 2.2 and 3.0.

Sorry if I overlooked some logic of the code.

Paal Erik