Bugs in fasham.F

Bug reports, work arounds and fixes

Moderators: arango, robertson

Post Reply
Message
Author
User avatar
m.hadfield
Posts: 521
Joined: Tue Jul 01, 2003 4:12 am
Location: NIWA

Bugs in fasham.F

#1 Unread post by m.hadfield »

A couple of bugs in ROMS 2.1 fasham.F, discovered while compiling on a Cray T3E with ASSUMED_SHAPE undefined:
  • 1) If none of the DIAGNOSTICS options is defined, then the Cray compiler issues a warning (non-fatal) about line 24...

    Code: Select all

          USE mod_diags
    
    ...because the module is empty. The warning can be suppressed by enclosing the line in an #ifdef block, ie

    Code: Select all

    # if defined DIAGNOSTICS_BIO
          USE mod_diags
    # endif
    
    2) Line 116...

    Code: Select all

          real(r8), intent(in) :: z_w(LBi:UBi,LBj:UBj,UBk)
    
    ...is incorrect and should be...

    Code: Select all

          real(r8), intent(in) :: z_r(LBi:UBi,LBj:UBj,UBk)
    
Cheers

User avatar
arango
Site Admin
Posts: 1367
Joined: Wed Feb 26, 2003 4:41 pm
Location: DMCS, Rutgers University
Contact:

#2 Unread post by arango »

Yes, good catch :!:

Thank you, H

Post Reply