Unable to compile WC13/RBL4DVAR_split test

[rtoste]

Dear colleagues,

I am trying to be familiar with the split 4dvar algorithms but I am encountering some issues during compilation.

I have already worked with RBL4dvar in some applications but only using older versions of the code. So I've downloaded the ROMS's code and tests from github (for the first time).

I have compiled successfully both WC13/RBL4DVAR and WC13/I4DVAR_split test cases, but when I try to compile the WC13/RBL4DVAR_split test, I get an error message and the executable is not built.

I used the same way to compile the 3 tests:
./build_roms.sh -j 24

For WC13/RBL4DVAR_split, I get:

Code: Select all

Warning: CHARACTER expression will be truncated in assignment (20/40) at (1) [-Wcharacter-truncation]
rbl4dvar.f90:697:18:

  697 |               IF (find_string(var_name, n_var, 'ExtractFlag',i)) THEN
      |                  1
Error: Function ‘find_string’ at (1) has no IMPLICIT type
rbl4dvar.f90:368:33:

  368 |                 string=ObsName(i)
      |                                 1
Warning: CHARACTER expression will be truncated in assignment (20/40) at (1) [-Wcharacter-truncation]
make: *** [ROMS/Drivers/Module.mk:14: /home/public/oceano/teste/wc13_split/Build_romsM/rbl4dvar.o] Error 1

The compilation outputs for the WC13/RBL4DVAR (successfully completed) and WC13/RBL4DVAR_split tests are attached for reference.

Does anyone know what I am doing wrong?


Thanks for the help

Raquel

[arango]

That's weird. I never got that error when I tested that update of the code — the mystery of compilers during linking. The compiler is telling you that it cannot find a module association to FUNCTION find_string. Indeed, in line 159 of ROMS/Drivers/rbl4dvar.F, we need to add such a function:

Code: Select all

      USE strings_mod,        ONLY : FoundError, find_string

Thank you for reporting this issue.

[rtoste]

Thanks, Arango. It is now compiling and running.

Just to report:
- the IO libraries sections are missing in both NL and DA input script templates
- using my compiler, the increment phase stucks on computation of the new Ritz eigenvalues. Running with debug on, it passes from this point. Therefore, I am now running without the -ffast-math flag. Not sure how it will slow the running or if have any impacts on the results, though.