TIMELESS_DATA

General scientific issues regarding ROMS

Moderators: arango, robertson

Post Reply
Message
Author
johnluick

TIMELESS_DATA

#1 Unread post by johnluick »

I happened to notice that (at least with version 3.7) ROMS did not write out the name of the tidal forcing file for a purely tidal-forced run until I changed line 4597 in read_phypar.F
from
#if defined FRC_FILE
to
#if defined FRC_FILE || defined TIMELESS_DATA
Not sure if that was the best fix but it worked.
Looking at the lines in globaldefs.h where FRC_FILE is defined it seemed like this could arise for other cases besides purely tidal.
Of course the program ran fine, it just didn't write out properly.

User avatar
arango
Site Admin
Posts: 1367
Joined: Wed Feb 26, 2003 4:41 pm
Location: DMCS, Rutgers University
Contact:

Re: TIMELESS_DATA

#2 Unread post by arango »

Yes, that would work for your particular set-up. However, the correct way is to modify the internal definition for FRC_FILE in globaldefs.h to:

Code: Select all

/*
** Define internal flag indicating processing of input forcing
** NetCDF file.
*/

#ifdef SOLVE3D
# ifdef BULK_FLUXES
#  ifdef ANA_SMFLUX
#   undef ANA_SMFLUX
#  endif
#  ifdef ANA_STFLUX
#   undef ANA_STFLUX
#  endif
# endif
# if !defined ANA_BTFLUX   || \
    (!defined AIR_OCEAN    && \
     !defined BULK_FLUXES  && !defined ANA_SMFLUX)   || \
    (!defined BULK_FLUXES  && !defined ANA_STFLUX)   || \
    ( defined BIOLOGY      && !defined ANA_SPFLUX)   || \
    ( defined BIOLOGY      && !defined ANA_BPFLUX)   || \
    ( defined BULK_FLUXES  && !defined LONGWAVE)     || \
    ( defined BULK_FLUXES  && !defined ANA_PAIR)     || \
    ( defined BULK_FLUXES  && !defined ANA_TAIR)     || \
    ( defined BULK_FLUXES  && !defined ANA_HUMIDITY) || \
    ( defined BULK_FLUXES  && !defined ANA_CLOUD)    || \
    ( defined BULK_FLUXES  && !defined ANA_RAIN)     || \
    ( defined BULK_FLUXES  && !defined ANA_WINDS)    || \
    ( defined BULK_FLUXES  && !defined ANA_SRFLUX)   || \
    ( defined LMD_SKPP     && !defined ANA_SRFLUX)   || \
    ( defined SALINITY     && !defined ANA_SSFLUX)   || \
    ( defined SOLAR_SOURCE && !defined ANA_SRFLUX)   || \
   (( defined TS_PSOURCE   || defined UV_PSOURCE     || \
      defined Q_PSOURCE)   && !defined ANA_PSOURCE)  || \
    ( defined  SSH_TIDES   || defined UV_TIDES)      || \
    ( defined BBL_MODEL    && (!defined ANA_WWAVE    && \
     !defined WAVES_OCEAN))                          || \
    ( defined SEDIMENT     && !defined ANA_SPFLUX)   || \
    ( defined SEDIMENT     && !defined ANA_BPFLUX)   || \
    ( defined WAVE_DATA    && (!defined ANA_WWAVE    && \
     !defined WAVES_OCEAN))                          ||
#  define FRC_FILE
# endif
#else
# if !defined ANA_SMFLUX   || \
    ( defined  SSH_TIDES   || defined UV_TIDES)
#  define FRC_FILE
# endif
#endif
 
Thank you for bringing this to my attention. I will load this correction today.

Post Reply